Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lronacpho to use LROC's newer photometric model and get parameters file from mission calibration directory #4512

Closed
victoronline opened this issue Jun 7, 2021 · 4 comments
Labels
enhancement New feature or request inactive Issue that has been inactive for at least 6 months Missions Issues which are a priority for missions

Comments

@victoronline
Copy link
Contributor

An update is needed to lronacpho to use the newer photometric model and newer parameters file.

This update needs to set the default photometric model (LROC_Empirical) to the newer model (2019) and look for the default parameters file in the data/mission/calibration directory. If the old parameter file is provided, the old algorithm(2014) will be used.

Default behavior:
SHould use a newer photometric model as default with the newer parameters file (NAC_PHO_LROC_Empirical.0003.pvl).

Optional behavior:
If another pvl is provided with and doesn't specify the algorithm version (NAC_PHO_LROC_Empirical.0001.pvl), then the old photometric model will be used.

If the 2014 version is specified, such as in NAC_PHO_LROC_Empirical.0002.pvl, then the old photometric model will be used.

@github-actions
Copy link

github-actions bot commented Dec 5, 2021

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Dec 5, 2021
@jessemapel jessemapel removed the inactive Issue that has been inactive for at least 6 months label Dec 6, 2021
@jessemapel
Copy link
Contributor

Pr is open

@jessemapel jessemapel mentioned this issue Apr 29, 2022
13 tasks
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label Jun 4, 2022
@jessemapel
Copy link
Contributor

Done in #4519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request inactive Issue that has been inactive for at least 6 months Missions Issues which are a priority for missions
Projects
None yet
Development

No branches or pull requests

2 participants