Changed base index.html to a redirect into the version/index.html #4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Create a redirect for the top level index file. It points to the version index file | ||
| execute_process(COMMAND ${XALAN} ${XALAN_VALIDATE_OPTION} ${XALAN_PARAM_OPTION} menuPath \"${docVersion}/\" ${XALAN_OUTFILE_OPTION} ${docInstallFolder}/index.html ${XALAN_INFILE_OPTION} ${docBuildFolder}/build/redirect.xml ${XALAN_XSL_OPTION} ${docBuildFolder}/build/redirect.xsl) | ||
| # Create the main documentaion page. This is located in the version directory | ||
| execute_process(COMMAND ${XALAN} ${XALAN_VALIDATE_OPTION} ${XALAN_PARAM_OPTION} menuPath \"\" ${XALAN_OUTFILE_OPTION} ${docInstallFolder}/${docVersion}/index.html ${XALAN_INFILE_OPTION} ${docBuildFolder}/build/homepage.xml ${XALAN_XSL_OPTION} ${docBuildFolder}/build/main.xsl) |
There was a problem hiding this comment.
I think passing through menuPath = "" would cause the UserStart, DevStart, etc. landing pages look like absolute paths rather than realtive ones.
There was a problem hiding this comment.
You are correct, looks like I dropped that somewhere. I'm testing now to make sure I put everything back corrctly.
There was a problem hiding this comment.
I was wrong, there is a docversion already in the path for the other doc pages, so putting in an empty string starts off with 7.0.0 for the main page and menus on the doc pages are usually .. or ../..
ladoramkershner
approved these changes
Mar 17, 2022
jessemapel
pushed a commit
to jessemapel/ISIS3
that referenced
this pull request
Apr 14, 2022
jessemapel
pushed a commit
that referenced
this pull request
Apr 14, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed base index.html to a redirect into the version/index.html## Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: