Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app3 #29

Open
DLLORENZ opened this issue Jun 15, 2019 · 0 comments
Open

app3 #29

DLLORENZ opened this issue Jun 15, 2019 · 0 comments

Comments

@DLLORENZ
Copy link

In the rush to get rloadest released, some applications did not really get completed. App3 is a case in point--the model is not really well resolved. Below are my suggestions for improving the model.

Figure 6 should be better commented and refined to better show the relation between flow and the timing of residuals. I suggest the code for figure 6 should be modified to:

# setSweave is required for the vignette.
setSweave("app3_06", 5, 5)
AA.pl <- timePlot(app3.calib$Date, residuals(app3.lra),
Plot=list(what="points"), ytitle="Residuals")
refLine(horizontal=0)
# show water years
refLine(vertical=as.Date("2001-10-01") + years(0:9))
# show low flow values in red
picks <- app3.calib$Flow < median(app3.calib$Flow)
addXY(app3.calib$Date[picks], residuals(app3.lra)[picks], Plot=list(what="points", color="red"))
graphics.off()

The first sentence in the describing paragraph should be expanded from:
The residuals for water-year 2002 are mostly greater than 0; those for watery-year 2003 are
trending down and those for water-year 2004 are mostly less than 0.
to:
The residuals for water-year 2002 are mostly greater than 0 and lower than normal flow; those for water-year 2003 are trending down and those for water-year 2004 are mostly less than 0 and represent greater than normal flow.

The diagnostic plots should for the anomaly model should include HFV, which indicates that a second order fit is suggested for HFV. The improved model is:
app3.lra <- loadReg(OrthoPhosphate.PO4 ~ a1yr + quadratic(HFV) + dectime(Date)
+ fourier(Date),
data = app3.calib,
flow = "Flow", dates = "Date",
station="Potomac River at Chain Bridge, at Washington, DC")

I got Bp down to about 13% and a much better E value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant