Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLOG conflict with protoDebug #87

Open
Ry-Kode opened this issue Sep 14, 2024 · 0 comments
Open

PLOG conflict with protoDebug #87

Ry-Kode opened this issue Sep 14, 2024 · 0 comments

Comments

@Ry-Kode
Copy link

Ry-Kode commented Sep 14, 2024

Hello,

Thank you for sharing your excellent work!

I ran into a conflict when including the NORM library (actually the protolib submodule) into my own project.

Both the NORM library (via protoDebug.h) and my project are using PLOG for logging. Both are defining logging macros, such as PLOG_INFO, but they use different log levels (e.g., ProtoDebugLevel vs. plog::Severity). This results in a type mismatch when the PLOG_INFO macro is expanded.

My suggestion would be to wrap the macros in a distinct namespace. This way, when you include both PLOG and protoDebug, you can explicitly refer to which logging system you are using.

@Ry-Kode Ry-Kode changed the title PLOG conflict with protoDefs PLOG conflict with protoDebug Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant