Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Water balance error in lake model #308

Closed
tbohn opened this issue Nov 17, 2015 · 2 comments
Closed

Water balance error in lake model #308

tbohn opened this issue Nov 17, 2015 · 2 comments
Assignees
@tbohn
Labels
bug
Milestone
4.2.c

Comments

@tbohn
Copy link
Contributor

tbohn commented Nov 17, 2015

The lake model in release 4.2 is exhibiting water balance errors. Currently investigating to find the source of the problem.

So far, I have found at least one part of the problem: the variable out_prec, used only for reporting precipitation for output, was not being updated correctly in full_energy.c. This only affects the water balance check in put_data.c (as well as making the output precipitation not equal the input precipitation). This is easy to fix. However, after fixing this, there are still water balance errors, which I am investigating now.
@tbohn tbohn mentioned this issue Nov 17, 2015
Closed
@tbohn
Copy link
Contributor Author

tbohn commented Nov 17, 2015

As it turns out, the OUT_PREC bug is the only code bug. The other issue was caused by a bad parameter value, for which I have added some extra validation in read_lakeparam.c.

@tbohn tbohn mentioned this issue Nov 30, 2015
Merged
@tbohn
Copy link
Contributor Author

tbohn commented Dec 8, 2015

@jhamman this issue can be closed since you've merged pull request #316

@jhamman jhamman closed this as completed Dec 8, 2015
@jhamman jhamman added this to the 4.2.c milestone Dec 8, 2015
@jhamman jhamman added the bug label Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbohn tbohn

Labels
bug
Projects
None yet
Milestone
4.2.c
Development

No branches or pull requests
2 participants
@jhamman @tbohn