Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: make ET partitioning more explicit #765

Closed
tbohn opened this issue Dec 31, 2017 · 2 comments
Closed

Cleanup: make ET partitioning more explicit #765

tbohn opened this issue Dec 31, 2017 · 2 comments

Comments

@tbohn
Copy link
Contributor

tbohn commented Dec 31, 2017

  • Version: VIC 5.0.1 develop branch
  • Problem: the logic in computing soil evaporation (esoil) is not very clean nor does it make clear which portion of ET comes from esoil, until the partitioning is cleared up in put_data().
  • Another problem: the default value of RARC_SOIL (architectural resistance for soil evaporation) is currently set to 100 s/m. Evaluation of VIC performance at Ameriflux towers suggests a more optimal value would be 250 s/m.
  • Solution: (a) introduce explicit esoil, transp, and evap terms into the layer struct; (b) remove the bare_evap_frac term; (c) modify logic in func_surf_energy_bal() and other functions to use these terms; (d) make the logic cleaner; and (e) change the default value of RARC_SOIL to 250.0 s/m.
@tbohn tbohn mentioned this issue Dec 31, 2017
6 tasks
@jhamman jhamman added the cleanup label Jan 2, 2018
@jhamman jhamman added this to the 5.1.0 (Next minor release) milestone Jan 2, 2018
@tbohn
Copy link
Contributor Author

tbohn commented Jan 2, 2018

I've broken out the change to the default SOIL_RARC value into another issue (#767). I subsequently closed that issue. It turns out that there are other issues impacting soil evaporation. Trying to optimize SOIL_RARC without addressing these other issues might give us the right answer for the wrong reason (compensating errors). These other issues need to be addressed first, before attempting to optimize SOIL_RARC.

@tbohn tbohn mentioned this issue Feb 3, 2018
6 tasks
@tbohn
Copy link
Contributor Author

tbohn commented Sep 28, 2018

Addressed in #777

@tbohn tbohn closed this as completed Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants