Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect root fraction calculation #793

Closed
tbohn opened this issue May 21, 2018 · 1 comment
Closed

[Bug] Incorrect root fraction calculation #793

tbohn opened this issue May 21, 2018 · 1 comment

Comments

@tbohn
Copy link
Contributor

tbohn commented May 21, 2018

  • VIC version: 5.1.0.rc1
  • Problem Description:
    -- In some cases, calc_root_fraction() computes substantially different root fractions from those of prior releases. This leads to substantially different rates of transpiration.
    -- This change arose in PR improve floating point comparisons in vic_init.c #701, which included some general cleanup fixes, including a fix to calc_root_fraction.c that was intended to fix problems with occasional cases of infinite loops in the algorithm. The fix did eliminate infinite loops, but changed the apportioning of root fractions to soil layers. One line in particular seems to have caused the change in apportioning: zone ++; was inserted on line 137.
  • Proposed Solution:
    -- Fix the algorithm to apportion correctly and also end the loop correctly.
@dgergel
Copy link
Contributor

dgergel commented May 31, 2018

Closed via #794

@dgergel dgergel closed this as completed May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants