Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to typo in image driver vic_force.c #673

Closed
tbohn opened this issue Jan 25, 2017 · 1 comment
Closed

Fix to typo in image driver vic_force.c #673

tbohn opened this issue Jan 25, 2017 · 1 comment
Assignees
@tbohn
Labels
cleanup
Milestone
5.0.2 (Next bug r...

Comments

@tbohn
Copy link
Contributor

tbohn commented Jan 25, 2017 •
edited
Loading

VIC 5.0.0 image driver - OS, compiler, settings, etc., are unimportant

In vic_force.c, for the "fcan" variable, the code expects the forcing file to name this variable "fcov". This needs to be changed to "fcan" to match VIC's name for the variable.

(In fact, the reason this instance of "fcov" exists is due to an incomplete conversion of the variable name from "fcov" to "fcan" throughout the code, which I was responsible for - this is simply a mistake.)

The fix for this should be extremely minor and will have no effects on existing tests or performance since this feature is not yet commonly used.
@yixinmao yixinmao mentioned this issue Jan 26, 2017
Closed
@bartnijssen bartnijssen added this to the 5.0.2 (Next next bug release) milestone Jan 31, 2017
bartnijssen added a commit to bartnijssen/VIC that referenced this issue Aug 25, 2017
@bartnijssen
Renamed fcov to fcan per UW-Hydro#673
c21f21e
bartnijssen added a commit to bartnijssen/VIC that referenced this issue Aug 25, 2017
@bartnijssen
Added release not for fixing UW-Hydro#673
425d7cf
bartnijssen added a commit to bartnijssen/VIC that referenced this issue Aug 25, 2017
@bartnijssen
Added release not for fixing UW-Hydro#673
ff740ee
bartnijssen added a commit to bartnijssen/VIC that referenced this issue Aug 25, 2017
@bartnijssen
Renamed fcov to fcan per UW-Hydro#673
ff816ff
@bartnijssen bartnijssen mentioned this issue Aug 25, 2017
Merged
3 tasks
jhamman pushed a commit that referenced this issue Aug 25, 2017
@bartnijssen
Fix/issue673 (#742)
bfdb4a6 
* Added release not for fixing #673

* Renamed fcov to fcan per #673

* Fixed releasenotes in response to review by jhamman
@jhamman
Copy link
Member

jhamman commented Aug 25, 2017

close via #742

@jhamman jhamman closed this as completed Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbohn tbohn

Labels
cleanup
Projects
None yet
Milestone
5.0.2 (Next bug release)
Development

No branches or pull requests
3 participants
@bartnijssen @jhamman @tbohn