Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU testing action using GitHub larger runner #713

Open
NicolasJPosey opened this issue Oct 14, 2024 · 1 comment
Open

Add GPU testing action using GitHub larger runner #713

NicolasJPosey opened this issue Oct 14, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request GPU

Comments

@NicolasJPosey
Copy link
Contributor

With the move to the UW Enterprise account, we should have access to GitHub's larger runners which include extra resources such as GPU-powered runners. This should allow us to implement tests that run on a GPU resource using GitHub Actions. I am proposing the following items to better separate the CPU- and GPU-based testing actions:

  • Some of the lines of the test.yml look like they should be shared between CPU and GPU actions. Thus, we should refactor test.yml into a TestBase.yml and a CPUTest.yml.

  • The "run unit tests" in the test.yml is likely just CPU tests (should be confirmed if it's not obvious) so the ./tests should be renamed to ./cpu_tests

    • This will require documentation updates in areas such as the Quick Sanity Test page that reference ./tests.
  • Implement a GPUTest.yml file with a simple GPU unit test and hook up to the GPU-powered runner.

    • Implementing the GPU unit test will require adding an if(ENABLE_CUDA) block to the TESTS EXECUTABLE section of the CMakeLists.txt file.
    • We may be able to reuse the CPU pattern with GoogleTest to build the GPU unit tests at this stage.
@NicolasJPosey NicolasJPosey added enhancement New feature or request GPU labels Oct 14, 2024
@NicolasJPosey NicolasJPosey self-assigned this Oct 14, 2024
@stiber
Copy link
Contributor

stiber commented Oct 17, 2024

I suggest breaking into 3 parts: unit tests, CPU tests, GPU tests. I agree that unit tests can just be for CPU right now.

Should also set up the actions so they only run if applicable files change. No sense in running any of these, for example, if someone modifies documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GPU
Projects
None yet
Development

No branches or pull requests

2 participants