New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this EventBuffer comment wrong, or is the code wrong? #736

Open

stiber opened this issue Nov 23, 2024 · 0 comments

Labels

good first issue question

Contributor

stiber commented Nov 23, 2024

Comment (linked below) says that EventBuffer size is max+1, but the code in EventBuffer.cpp looks like it's only max.

Graphitti/Simulator/Vertices/EventBuffer.h

Lines 40 to 41 in b507ae9

    
           /// bug in the simulator). Note that the buffer size will be set to maxEvents+1, to distinguish between 
        
           /// an empty and a full buffer.

The text was updated successfully, but these errors were encountered:

stiber added good first issue question labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment