Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vaultwarden] guide is broken #1100

Closed
schneider-de-com opened this issue Aug 31, 2021 · 3 comments
Closed

[vaultwarden] guide is broken #1100

schneider-de-com opened this issue Aug 31, 2021 · 3 comments

Comments

@schneider-de-com
Copy link
Contributor

The guide for Vaultwarden does not work anymore. After entering the command "cargo build -j 1 --release --features sqlite" build stops with the message that there are modules that are not needed. We added a banner to the guide to signal the broken state.

If you have any insights, please comment on this issue. Pull requests fixing the guide are also highly appreciated. If the guide does not get fixed within two months, we will remove it from the lab, as documented in the broken guides policy.

@brutus @sruf @quadratmuede @pxlfrk FYI.

@pxlfrk
Copy link
Contributor

pxlfrk commented Sep 3, 2021

Hey @permanentmedia, thanks for your Contribution and hint regarding the error.
I am the original author of the guide and tested the guide in its current state yesterday on a brand new uberspace.

I can confirm the warning you describe, but it's just a compiler warning, not an error.
If you let run the build process after the warning shows the build finishes as expected.

[user@host vaultwarden]$ cargo build -j 1 --release --features sqlite
   Compiling vaultwarden v1.0.0 (/home/$USER/vaultwarden)
warning: unused imports: `Build`, `Rocket`, `self`
  --> src/util.rs:7:15
   |
7  |     fairing::{self, Fairing, Info, Kind},
   |               ^^^^
...
10 |     Data, Request, Response, Rocket, Build
   |                              ^^^^^^  ^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: 1 warning emitted

    Finished release [optimized] target(s) in 8m 53s

So instead of marking the guide as broken i would prefer adding a hint that a warning may occur.
Some words regarding the needed workaaround with the async-branch:
Vaultwarden is build upon/with Rocket that in turn needs a rust nightly or dev version to compile successfully (see #708). Rocket has alredy implemented rust stable, this changes will be released with Rocket 0.5 which is mostly finished. As soon as this new Rocket version is released, vaultwarden will update its dependencies and our patch and hopefully also this warning will be gone.

@schneider-de-com
Copy link
Contributor Author

Hey @pxlfrk

thank you for analysing the warning.

My Uperspace was not a new Uberspace unfortunately, turning off all other services helped complete the build process.

I think the hint that the build process consumes a lot of RAM and all other processes should be shut down is also helpful.

@noave
Copy link
Contributor

noave commented Dec 13, 2021

closing here because the dependency issues of vaultwarden are already handled in #708 and the memory issue came up again at #1160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants