Add guide for healthchecks #1738
Conversation
| [isabell@stardust ~]$ python3.11 -m venv venv | ||
| [isabell@stardust ~]$ source venv/bin/activate | ||
| (venv) [isabell@stardust ~]$ pip3.11 install -r requirements.txt | ||
| Collecting aiosmtpd==1.4.4.post2 (from -r requirements.txt (line 1)) |
There was a problem hiding this comment.
Do you want me to keep all the log output from that command? Or should I somehow abbreviate it?
There was a problem hiding this comment.
That's pretty long, please abbreviate it like in the Kimai Guide.
There was a problem hiding this comment.
Abbreviate it now. Could you resolve the conversation if you like it?
|
|
||
| :: | ||
|
|
||
| (venv) [isabell@stardust ~]$ python3.11 ./manage.py migrate |
There was a problem hiding this comment.
Here (and also in some of the following listings) I assume that the user is still in the active virtualenv. Do you want me to repeat the source venv/bin/activate command before each of the commands requiring the virtualenv?
There was a problem hiding this comment.
Good question. If this was my guide I would provide a note before the first use of the venv with something like that:
.. note:: All following commands require the virtualenv, you can activate it with ``source venv/bin/activate`` in a new SSH-session
There was a problem hiding this comment.
I prefixed all the commands that require a virtual env with (venv). I assume that's clear for every reader.
| :: | ||
|
|
||
| (venv) [isabell@stardust ~]$ python3.11 ./manage.py migrate | ||
| System check identified some issues: |
There was a problem hiding this comment.
Again long log output that could be abbreviated.
There was a problem hiding this comment.
Yeah it makes sense to abbreviate, there is no upside in keeping all of it.
|
Thanks for the responses. I'll take care of them at the end of the week! |
|
Any news here? If there's no feedback we'll close the PR. |
|
Hey @nichtmax, |
MetroMarv
force-pushed
the
1724/add-guide-for-healthchecks
branch
from
277b6f6 to
7102fa7
Compare
| @@ -2,7 +2,7 @@ | |||
| # INSTALL .: `pre-commit install --overwrite --install-hooks` | |||
| # UPDATE ..: `pre-commit autoupdate` | |||
| default_language_version: | |||
| python: python3.10 | |||
| python: python3 | |||
There was a problem hiding this comment.
I had apply the changes of #1856 to make it work on my system. And I didn't find a way to work around this. Please let me know if there is any way.
|
I addressed all open conversations now. Could you please have one more look and resolve the conversations? Thank you very much :) |
Fixes #1724