UiPath orchestrator AWS template default parameter QSS3KeyPrefix must be quickstart-uipath-orchestrator not quickstart-uipath-robot

[obriensystems]

Describe the bug
Running the default AWS deployment for full HA fails by default on the nested orchestrator template because the default s3 template variable references quickstart-uipath-robot instead of *-orchestrator - causing a CF failure on the 2nd nested template creation

Product and Cloud
Latest default UiPath template with new VPC in https://aws-quickstart.github.io/quickstart-uipath-orchestrator/#_launch_the_quick_start

Expected behavior
Template should run to completion - it fails

Additional context
in https://aws-quickstart.github.io/quickstart-uipath-orchestrator/#_launch_the_quick_start via
https://github.com/UiPath/Infrastructure
specifically
https://github.com/UiPath/Infrastructure/blob/main/AWS/Orchestrator/templates/main.template.yaml#L983

without the orchestrator change/ for

2021-04-14 19:20:35 UTC-0400
OrchestratorStack
CREATE_FAILED
S3 error: The specified key does not exist.

"finding key"
https://github.com/UiPath/Infrastructure/blob/main/AWS/Orchestrator/templates/main.template.yaml#L983

OrchestratorStack:
Type: 'AWS::CloudFormation::Stack'
Properties:
TemplateURL: !Sub
- >-
https://${S3Bucket}.s3.${S3Region}.${AWS::URLSuffix}/${QSS3KeyPrefix}templates/uipath-orchestrator.template.yaml
others ok
https://${S3Bucket}.s3.${S3Region}.${AWS::URLSuffix}/${QSS3KeyPrefix}submodules/quickstart-aws-vpc/templates/aws-vpc.template

S3 URL: https://aws-quickstart.s3.us-east-1.amazonaws.com/quickstart-uipath-orchestrator/templates/main.template.yaml

using

QSS3BucketName = aws-quickstart

QSS3BucketRegion = us-east-1
QSS3KeyPrefix = quickstart-uipath-robot/ (change to quickstart-uipath-orchestrator/

should be (works)
https://aws-quickstart.s3.us-east-1.amazonaws.com/quickstart-uipath-robot/templates/uipath-orchestrator.template.yaml

should be
https://aws-quickstart.s3.us-east-1.amazonaws.com/quickstart-uipath-orchestrator/templates/uipath-orchestrator.template.yaml

continuing/rerun

2021-04-14 20:48:01 UTC-0400	UiPath-Orchestrator	CREATE_COMPLETE	-
2021-04-14 20:47:58 UTC-0400	OrchestratorStack	CREATE_COMPLETE	-
2021-04-14 19:44:41 UTC-0400	OrchestratorStack	CREATE_IN_PROGRESS	Resource creation Initiated
2021-04-14 19:44:40 UTC-0400	OrchestratorStack	CREATE_IN_PROGRESS	-
2021-04-14 19:44:38 UTC-0400	NetworkStack	CREATE_COMPLETE	-
2021-04-14 19:41:34 UTC-0400	NetworkStack	CREATE_IN_PROGRESS	Resource creation Initiated
2021-04-14 19:41:33 UTC-0400	NetworkStack	CREATE_IN_PROGRESS	-
2021-04-14 19:41:26 UTC-0400	UiPath-Orchestrator	CREATE_IN_PROGRESS	User Initiated

start 1941
HA slaves up 1945
bastion up 2045

[AndreiBarbuOz]

thanks @obriensystems,
the issue comes from this default value:

Infrastructure/AWS/Orchestrator/templates/main.template.yaml

Line 934 in ebfea98

Default: quickstart-uipath-robot/

which needs to be replaced with quickstart-uipath-orchestrator

[obriensystems]

replaced/verified in https://github.com/obrienlabs/uipath/blob/main/cloudformation/templates/main.template.yaml#L947