NP-310 wasm bindings #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new feature has been added to provide JavaScript bindings using Emscripten. This includes changes in the Conan package settings and CMake settings, along with the creation of jsDulcificum.cpp file for the actual bindings. Extra precautions have been taken to only use threads when not targeting Emscripten. The package settings were also updated to handle situations when python bindings are required. Files necessary for Emscripten are copied appropriately during the build process. Contributes to NP-76
Changed the TypeScript definition file name from "dulcificum.d.ts" to "jsdulcificum.d.ts" in the CMakeLists. This update will ensure that naming conventions are consistent across the project. Contributes to NP-76
Removed the standalone CMakeList for jsDulcificum and incorporated it into the main CMakeLists file, streamlining the build process Also updated the binding of the gcode_2_miracle_jtp function in jsDulcificum.cpp to ensure the correct function is called. Contributes to NP-76
jellespijker
requested changes
Jul 31, 2024
Updated workflow files and CMakeLists.txt to reflect the new naming convention. NP-76
Updated package.json scripts and imports in index.ts to use the new file name. Added a new CMakeLists.txt for DulcificumJS and reorganized the main CMakeLists.txt accordingly. NP-76
NP-76
Adjusted `copy:js` script to use `mkdir` and `cp` instead of Windows-specific commands. Updated Conan package reference in GitHub workflow to the correct repository. NP-76
NP-76
NP-76
NP-76
NP-76
NP-76
Np-78
casperlamboo
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.