Fix 2024.6 masks not showing #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
requested changes
Nov 25, 2024
Comment on lines
350
to
352
| // Not in the data file | ||
| public uint Width { get; set; } | ||
| public uint Height { get; set; } |
There was a problem hiding this comment.
Please add proper XML documentation for these.
There was a problem hiding this comment.
Are you for real? What documentation can I write about Width and Height?!?!
There was a problem hiding this comment.
Written in discord but also writing here for prosperity:
Mentioning that its the width/height of the clipmask and an utmt only attribute would suffice for me.
A docstring does not need to be a full essay
Miepee
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In GMS 2024.6, masks have the size of the bounding box instead of the same as the sprite. This caused them to not display in the UI if these sizes were different. This PR makes so the mask size is stored so it's displayed correctly in the UI.
Caveats
None
Notes
Here's a data.win that has a mask which would not work without theses changes: fix-2024-6-masks-test.zip