Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GENERAL] Document API responses #4

Closed
raintonr opened this issue Feb 4, 2016 · 4 comments
Closed

[GENERAL] Document API responses #4

raintonr opened this issue Feb 4, 2016 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@raintonr
Copy link

raintonr commented Feb 4, 2016

I notice there are various REST requests documented in the readme.md. However, there are no responses described. For completeness the responses to each request on success/failure should be documented.

@sworteu
Copy link

sworteu commented Mar 26, 2016

It's hard to understand the http evok responses without documentation. it's true.

@tknot tknot self-assigned this Aug 9, 2017
@tknot tknot added the enhancement New feature or request label Aug 10, 2017
@tknot tknot changed the title Document API responses [GENERAL] Document API responses Sep 14, 2017
@wesleydv
Copy link

I believe this issue is bigger than just the API responses. Documentation of the API should be way better than what it is now.
All the request, their arguments and their possible responses should be documented, preferably in a structured way.

A possible way of doing this would be using the OpenAPI Specification, maybe in combination with a tool like https://editor.swagger.io/
However the OpenAPI Specification does not support RPC.
But just documenting the REST API alone would be a huge step forward.

@tknot
Copy link
Contributor

tknot commented Oct 9, 2017

We have a tentative implementation of JSON schema for the Rest API, which can be used to import into certain API services (we are thinking of using RAML specifically, but it's fully convertible to swagger as well).

We are planning of doing something similar, though it probably won't make it into the next release (due sometime this week) just yet, as there is quite a bit of work involved in implementing it.

@tknot tknot added the request label Oct 9, 2017
@tknot
Copy link
Contributor

tknot commented Nov 2, 2017

The API responses are now documented in the API-DOCS.IO link. It uses similar format as swagger, but it has custom additions to allow us to represent some things that Swagger cannot do (polymorphic arrays in particular, at least without remaking the API to use Swaggers discriminator, see OAI/OpenAPI-Specification#333 in particular)

You can also download the schema from api-docs in OAS (i.e. Swagger) or RAML format.

@tknot tknot closed this as completed Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants