You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would change them to be like the others, and more obvious, as follows:
end_of_line values ["windows", "unix", "native"]
indent_char values ["space", "tab"]
Also, I would maybe drop the native newline setting. In a multi-OS dev team, that would cause the files to be converted back and forth between Unix and Windows newlines. (Unless Git is set to do its own newline conversion back and forth, but that brings us to another issue: there's a subtle interaction between Git's and Unibeautify's newline conversion mode, which a native choice would complicate even further.) IMHO, the ideal is for the beautifier to force a particular newline encoding on all platforms. All serious programmer's text editors can handle any newline encoding on any platform.
The text was updated successfully, but these errors were encountered:
Also, I would maybe drop the native newline setting. In a multi-OS dev team, that would cause the files to be converted back and forth between Unix and Windows newlines.
💯% agree and I was thinking about that a few months ago.
All enum values in
options.ts
seem to be spelled usinglowercase-with-dashes
.Except for 2 enums:
end_of_line
values["CRLF", "LF", "System Default"]
indent_char
values[" ", "\t"]
I would change them to be like the others, and more obvious, as follows:
end_of_line
values["windows", "unix", "native"]
indent_char
values["space", "tab"]
Also, I would maybe drop the
native
newline setting. In a multi-OS dev team, that would cause the files to be converted back and forth between Unix and Windows newlines. (Unless Git is set to do its own newline conversion back and forth, but that brings us to another issue: there's a subtle interaction between Git's and Unibeautify's newline conversion mode, which anative
choice would complicate even further.) IMHO, the ideal is for the beautifier to force a particular newline encoding on all platforms. All serious programmer's text editors can handle any newline encoding on any platform.The text was updated successfully, but these errors were encountered: