Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tests failing with Pint 0.10 #1271

Closed
dopplershift opened this issue Jan 6, 2020 · 0 comments · Fixed by #1282
Closed

Image tests failing with Pint 0.10 #1271

dopplershift opened this issue Jan 6, 2020 · 0 comments · Fixed by #1282
Labels
Area: Plots Pertains to producing plots Area: Tests Affects tests Area: Units Pertains to unit information
Milestone

Comments

@dopplershift
Copy link
Member

Saw these with the "build against master" test matrix entry, but thought they were due to xarray--turns out when doing a sweep against pint master I forgot to run the image tests. Oops.

Good news, is that looking at the output of the examples, things work in general. The tests show a few failure modes:

  1. Getting negative 0 instead of positive
  2. degC -> degrees_Celsius (yuck)
  3. Station plot tests giving back text with units instead of just the values (so "20" -> "20 degrees_Celsius")

Not sure if these are truly edge case bugs or just some flaws in the tests...

@dopplershift dopplershift added Area: Plots Pertains to producing plots Area: Tests Affects tests Area: Units Pertains to unit information labels Jan 6, 2020
@dopplershift dopplershift added this to the 1.0 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Area: Tests Affects tests Area: Units Pertains to unit information
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant