Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more quantize testing #2454

Closed
edwardhartnett opened this issue Jul 8, 2022 · 1 comment · Fixed by #2457
Closed

more quantize testing #2454

edwardhartnett opened this issue Jul 8, 2022 · 1 comment · Fixed by #2457

Comments

@edwardhartnett
Copy link
Contributor

In light of @czender recent discovery of issue #2441, I think I need to beef up quantize testing.
This was referenced Jul 8, 2022
Closed
Merged
@edwardhartnett
Copy link
Contributor Author

OK, so with PR #2457 all the existing quantize tests were extended to test:

  • With and without NC_CLASSIC_MODEL
  • All three quantize algoritms.

@DennisHeimbigner I don't think this will impact the way you are using tst_quantize to test nczarr. And all my tests pass, so please let me know if there is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@edwardhartnett