Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to control URL encoding for DAP2 #1884

Merged
merged 3 commits into from
Nov 13, 2020

Commits on Nov 5, 2020

  1. Yet another fix for DAP2 double URL encoding.

    re:  Unidata#1876
    and: Unidata#1835
    and: Unidata/netcdf4-python#1041
    
    The change in PR 1835 was correct with respect to using %20 instead of '+'
    for encoding blanks. However, it was a mistake to assume everything was
    unencoded and then to do encoding ourselves. The problem is that
    different servers do different things, with Columbia being an outlier.
    
    So, I have added a set of client controls that can at least give
    the caller some control over this. The caller can append
    the following fragment to his URL to control what gets encoded before
    sending it to the server. The syntax is as follows:
    ````
    https://<host>/<path>/<query>#encode=path|query|all|none
    ````
    
    The possible values:
    * path  -- URL encode (i.e. %xx encode) as needed in the path part of the URL.
    * query -- URL encode as needed in the query part of the URL.
    * all   -- equivalent to ````#encode=path,query````.
    * none  -- do not url encode any part of the URL sent to the server; not strictly necessary, so mostly for completeness.
    
    Note that if "encode=" is used, then before it is processed, all encoding
    is turned of so that ````#encode=path```` will only encode the path
    and not the query.
    
    The default is ````#encode=query````, so the path is left untouched,
    but the query is always encoded.
    
    Internally, this required changes to pass the encode flags down into
    the OC2 library.
    
    Misc. Unrelated Changes:
    * Shut up those irritating warning from putget.m4
    DennisHeimbigner committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    793ecc8 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    32f0bc2 View commit details
    Browse the repository at this point in the history
  2. Add encode= tests

    DennisHeimbigner committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    6d3546b View commit details
    Browse the repository at this point in the history