Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shell handling of escapes #1989

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Fix shell handling of escapes #1989

merged 2 commits into from
Apr 22, 2021

Commits on Apr 21, 2021

  1. Fix shell handling of escapes 

    re: Unidata#1988

There was an issue with certain shell programs (bash notably).
For certain platforms and when given a url that had an escaped
'#' character (e.g. \\#) bash would not remove the backslash. So I
had to add a hack for this. Unfortunately I overdid it and it
removed all '' characters. This is ok for non-windows platforms,
but obviously fails for windows.

The fix is this.

1. In a utility program (ncgen, ncdump, nccopy, etc) there is probably a call (or calls) to NC_backslashUnescape(xxx) where xxx is a path argument from the command line.
2. Replace each such call with NC_shellUnescape(xxx).

The NC_shellUnescape function was added and searched only for occurrences of "\#" and replaces them with "#".
    @DennisHeimbigner
    DennisHeimbigner committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    efd1be5 View commit details
    Browse the repository at this point in the history

  2. Update RELEASENOTES

    @DennisHeimbigner
    DennisHeimbigner committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    2bdc00c View commit details
    Browse the repository at this point in the history