Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option --enable-extra-example-tests can be removed, extra tests can be always enabled #126

Closed
edhartnett opened this issue Feb 14, 2019 · 0 comments · Fixed by #125
Closed

Comments

@edhartnett
Copy link
Contributor

In the examples/F77 directory we run our classic tests, and, if netCDF-4 is built into the C library, we add the netCDF-4 F77 tests.

In the F90 directory we do the same, but also require that --enable-extra-example-tests be specified in configure, which surely no one is noticing or bothering with.

There is no reason not to run the F90 netCDF-4 examples, just as we run the F77 netCDF-4 examples, whenever netCDF-4 is present. We can remove the --enable-extra-example-tests to simplify our configure script and our CI testing.

I will take care of this in an upcoming PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant