Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake modernization #404

Closed
LecrisUT opened this issue Jun 14, 2023 · 3 comments
Closed

Cmake modernization #404

LecrisUT opened this issue Jun 14, 2023 · 3 comments

Comments

@LecrisUT
Copy link

This should be moved into the main netcdf-c project, ensuring the library versions are equivalent

@WardF
Copy link
Member

WardF commented Jun 15, 2023

These were split off after netcdf 4.1.3, and it is unlikely they will be recombined.

@WardF WardF closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@LecrisUT
Copy link
Author

Then please re-open as a mirror issue to Unidata/netcdf-c#2713. And in addition to those points:

  • make netcdf-c a submodule dependency
  • add an organization wide github workflow
  • synchronize or delegate one library to have the main cmake files (defining macros and so on)

I believe there are more disadvantages in keeping these organized as individual repositories and much more CI complexity to be designed and maintained than there is advantages. Is there a discussion for the split off decision to be read and can it be reconsidered in light of the advances of the build system tools?

@LecrisUT
Copy link
Author

@WardF, please re-open this issue because this is still relevant with the comments linked to the C library. Why is the fortran interface namespaced as netCDF::netcdft? It should be netCDF::Fortran or equivalent.

INSTALL(TARGETS netcdff netcdff_c
EXPORT netcdffTargets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants