Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGRA2 Cassette Missing #204

Closed
jrleeman opened this issue Mar 29, 2018 · 2 comments
Closed

IGRA2 Cassette Missing #204

jrleeman opened this issue Mar 29, 2018 · 2 comments
Labels
Area: Tests Area: Web Services Type: Bug
Milestone
0.8

Comments

@jrleeman
Copy link
Contributor

In #185 we discovered that vcr doesn't seem to be handling cassette generation for IGRA2 as it's an FTP request. We should look into having a customer serializer and/or contributing upstream.
@dopplershift
Copy link
Member

I think it's actually a "custom patcher" that would be used here.

@dopplershift dopplershift added this to the 0.8 milestone Mar 29, 2018
@dopplershift
Copy link
Member

Custom patcher will still want to do things with something that looks like an HTTPConnection. Easier just to monkey patch and open a local copy of data.

jrleeman added a commit that referenced this issue Jul 2, 2018
@jrleeman
Merge pull request #235 from dopplershift/igra-testing
eed47b2 
ENH: Make IGRA2 tests run offline (Fixes #204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Tests Area: Web Services Type: Bug
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
2 participants
@dopplershift @jrleeman