Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAState No Data Handling #205

Closed
2 tasks done
jrleeman opened this issue Mar 29, 2018 · 3 comments
Closed
2 tasks done

IAState No Data Handling #205

jrleeman opened this issue Mar 29, 2018 · 3 comments

Comments

@jrleeman
Copy link
Contributor

jrleeman commented Mar 29, 2018

When requesting an invalid date/station from IAState upper air our handler doesn't catch correctly. Not sure if it was a change on their end or if it didn't work right. (We didn't test that case in MetPy since we didn't have VCR).

  • Fix IA State handling (it's just a blank return with a 200)
  • Add tests for both services
@jrleeman
Copy link
Contributor Author

@akrherz If you request upper air data that's not available we get a sensible JSON return. If we request data from the future accidentally, there's just a blank page with a 200. Any chance to get either the JSON return or a 404?

@akrherz
Copy link
Contributor

akrherz commented Mar 30, 2018

@jrleeman thanks for reaching out, any happier now?

@jrleeman
Copy link
Contributor Author

That'll work! 👍 Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants