MNT: Silence a bunch of warnings about np.fromstring() #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy would really like us to use frombuffer() binary data rather than fromstring(). This elminates several hundred warnings when running the test suite with the latest NumPy.
dopplershift
requested review from
jrleeman and
lesserwhirls
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy would really like us to use frombuffer() binary data rather than fromstring(). This eliminates several hundred warnings when running the test suite with the latest NumPy.
The warnings about Pandas and setting attributes is back, but I think this is a problem with pytest 3.8, so I'll defer doing anything about them for now. This PR is enough to get things back under control at least.