Set dataset ID attribute #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siphon/catalog.py
Outdated
| @@ -454,6 +454,12 @@ def __init__(self, element_node, catalog_url=''): | |||
|
|
|||
| """ | |||
| self.name = element_node.attrib['name'] | |||
|
|
|||
| if 'ID' in element_node.attrib: | |||
| self.id = element_node.attrib['ID'] | |||
There was a problem hiding this comment.
self.id = element_node.attrib.get('ID', None) would be shorter... 😁
There was a problem hiding this comment.
Could technically do that to the 'urlPath' block below if you're feeling motivated...
siphon/catalog.py
Outdated
| if 'urlPath' in element_node.attrib: | ||
| self.url_path = element_node.attrib['urlPath'] | ||
| self.id = element_node.attrib.get('ID', None) |
There was a problem hiding this comment.
Did you really mean to move this line into the block? What I meant was that you could do, outside any if block
self.id = element_node.attrib.get('ID', None)
self.url_path = element_node.attrib.get('urlPath', None)
dopplershift
previously approved these changes
Oct 17, 2018
siphon/tests/test_catalog.py
Outdated
| 'text/tropical/atlantic/hdob/High_density_obs_20170824.txt'}) | ||
| assert (cat.datasets[0].access_urls | ||
| == {'HTTPServer': 'http://thredds-test.unidata.ucar.edu/thredds/' | ||
| 'fileServer/noaaport/text/tropical/atlantic/hdob/'' |
There was a problem hiding this comment.
Oops, note the '' at the end of the line.
|
Ok - I think everything is happy here now @dopplershift |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #233