Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NDBC for Pandas #265

Closed
dopplershift opened this issue May 24, 2019 · 2 comments
Closed

Update NDBC for Pandas #265

dopplershift opened this issue May 24, 2019 · 2 comments

Comments

@dopplershift
Copy link
Member

Apparently:

/Users/rmay/miniconda3/envs/unidata/lib/python3.7/site-packages/siphon/simplewebservice/ndbc.py:107: FutureWarning: read_table is deprecated, use read_csv instead.

Not sure how that will work, but here are the current offenders:

siphon/simplewebservice/ndbc.py
106:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
144:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
178:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
226:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
265:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
295:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
323:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
360:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
394:        df = pd.read_table(StringIO(content), comment='#', na_values='MM',
454:        df = pd.read_table(StringIO(resp.text), comment='#', na_values='MM',
@zbruick
Copy link
Contributor

zbruick commented Jul 1, 2019

read_table has been changed to read_csv in #269. All tests pass without any other changes needed, so I think this can be closed once the PR is merged.

@zbruick
Copy link
Contributor

zbruick commented Jul 18, 2019

Closed by #269.

@zbruick zbruick closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants