Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests in PyPI tarball #293

Merged

Conversation

kmosiejczuk
Copy link
Contributor

@kmosiejczuk kmosiejczuk commented Nov 15, 2019

In OpenBSD we use the regression tests in order to make sure that updates
work properly and that an update of a dependency doesn't break a package.
Having the regression tests in the PyPI tarball makes that much easier.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dopplershift
Copy link
Member

Thanks for the contribution. I'm actually surprised these aren't already included.

To be clear, you only need these included in the source distribution, correct? We're just looking soon at redoing the repository layout, and I want to make sure I keep the right use case in mind.

@kmosiejczuk
Copy link
Contributor Author

Thanks for the contribution. I'm actually surprised these aren't already included.

To be clear, you only need these included in the source distribution, correct? We're just looking soon at redoing the repository layout, and I want to make sure I keep the right use case in mind.

Correct. Just the source distribution.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated.

@dopplershift dopplershift merged commit 60c312d into Unidata:master Nov 15, 2019
@kmosiejczuk kmosiejczuk deleted the include-tests-in-pypi-tarball branch November 21, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants