-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
precipitable water import #298
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I can definitely see the use in having the precipitable water values that Wyoming provides available (I think we have ignored them in the past because we use MetPy to calculate). I just have a few questions/comments to address and we can get this in!
The suggestions that were laid were some cheap workarounds for local testing/running. Those changes have been adjusted such that the only real alteration is the inclusion of precipitable water in the data pull, as that was the goal. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor bit of lint to satisfy the bots, then this is ready to go.
I'm not sure what the deal with coverage is, but your changes look just fine.
If you want bonus points, you could test that the value of precipitable water is properly decoded here: siphon/siphon/tests/test_wyoming.py Lines 30 to 37 in f39e322
|
I can take a look and integrate precipitable water into the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precipitable water can be directly imported from the changes made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
Fixed a commit conflict previously missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved a units issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the contribution!
Description Of Changes
Updates to wyoming.py to allow Precipitable Water measurements to be pulled.
Checklist