Updating GitHub Infrastructure #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From MetPy.
We'll be doing this with GitHub Actions now.
These handle drafting a release when a milestone is closed and assigning the next milestone to any PR that is merged and not milestoned.
This runs GitHub's CodeQL and our own set of flake8 plugins.
Handles building the package and uploading to PyPI.
dopplershift
force-pushed
the
github
branch
7 times, most recently
from
56af6fc to
521a39e
Compare
Runs tests installing with both Conda and pip.
These have never been released and now are slated to move to MetPy instead. This also avoids needing to fix an NHC test for 2021.
unpack parameter is not needed for structured datatypes.
Need to make everything explicitly object arrays, which means some checks need adjusting.
Something seems to have broken with using VCRPy on the classmethods we use to setup test classes. It works just fine to use the context manager method, so just do that.
Code change in Unidata#321 to add a column actually fixed a bug where the last few columns were incorrect. Need to update the test to reflect this.
This code is more robust to changes in dimension naming on the TDS.
dcamron
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Checklist