MNT: Fix xarray support with xarray 0.10 #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesserwhirls
previously approved these changes
Nov 22, 2017
It looks like xarray 0.10 changed up how the backends operate, breaking our CDM support in the process. This seems to get things back to working.
dopplershift
force-pushed
the
fix-xarray
branch
from
aff3643
to
dcb07ef
Compare
|
Added docstrings--will need a new review. |
lesserwhirls
approved these changes
Nov 22, 2017
|
Need 0.10 packages to appear for windows for this to pass AppVeyor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like xarray 0.10 changed up how the backends operate, breaking
our CDM support in the process. This seems to get things back to
working.