-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change line 44 to include 0123 for day instead of 012 #173
Conversation
Apparently I commited this with the wrong email address.. Not sure how to get around that.. I signed the CLA with my github account, but that's associated with a different email than what I commited the change with.. (poker@hera.aos.wisc.edu, which is not even a valid email addr...) How can I fix this? |
Try running this:
Then do:
|
🎉 Are you interested in trying to write a test? Otherwise, (if you don’t mind) I can knock one out real quick and push to your branch. |
I'm not really sure where to start with that.. I'd appreciate it. Seeing one written, hopefully I can swing the next one. Thx! |
Probably should have @lesserwhirls or @jrleeman sign off since I've now committed on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for the contribution @pjpokran!
Fixes issue #172 so that filter_time_nearest searches for days 30 and 31 work properly.