Implement all-station IEM Upper Air request #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrleeman
suggested changes
Jun 29, 2018
siphon/simplewebservice/iastate.py
Outdated
| @@ -107,7 +138,7 @@ def _get_data(self, time, site_id): | |||
| 'time': None} | |||
| return df | |||
|
|
|||
| def _get_data_raw(self, time, site_id): | |||
| def _get_data_raw(self, time, site_id, pressure): | |||
There was a problem hiding this comment.
What if pressure defaulted to None?
Based on akrherz/iem#117, this commit implements the new all-station upper air request from Iowa State. Modifications were made to the parsing backend to allow for the returned JSON with multiple files.
jrleeman
approved these changes
Jul 2, 2018
There was a problem hiding this comment.
I'm happy - I'll merge by COB unless there is protest from @dopplershift or @lesserwhirls
dopplershift
approved these changes
Jul 2, 2018
|
FYI @bryanguarente that this is merged in master now! 🎆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the ability to request upper air data for all stations for a given time from the Iowa State archive via the
request_all_datamethod. Additionally, a separate commit in the PR adds the simple web services other thanwyomingto the docs.