Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI regression on replying message with touch pad #2662

Open
Jack-Works opened this issue Feb 17, 2022 · 13 comments
Open

UI regression on replying message with touch pad #2662

Jack-Works opened this issue Feb 17, 2022 · 13 comments

Comments

@Jack-Works
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

In this UI,

image

Swipe left use 2 fingers on the high precision touchpad on a message

Expected behavior

The message can be swiped left, and when the finger releases, it becomes the "reply" state.

image

In the newer version, this useful feature seems removed.

Version Info

  • Unigram: 8.5 (6982) x64
  • Windows: 10

Additional context
Add any other context about the problem here.

@makisukurisu
Copy link
Collaborator

Additional note: horizontal scroll causes vertical scroll in chat list and chat window.

@FrayxRulez
Copy link
Collaborator

I'm using the same version of the app and I can't reproduce the issue.
Additionally, there was no changes to this logic since October: https://github.com/UnigramDev/Unigram/commits/develop/Unigram/Unigram/Controls/Chats/ChatListViewItem.cs

@makisukurisu
Copy link
Collaborator

makisukurisu commented Feb 17, 2022

You can try to swipe between chats/contacts/calls/settings in Unigram.

Thanks for the report.
P.S. ELAN 21.2.27.1 doesn't inform system about swipe actions, apparently. Or it does, but in such a way modern apps cannot understand.

You can try to see if SwipeControl works for your machine in WinUI 3 Controls Gallery, if it does this issue must be investigated further, if it doesn't - this is caused by driver your trackpad is using (if you don't have one - you might want to see if there is any for your machine and try with it)

@Jack-Works
Copy link
Author

You can try to see if SwipeControl works for your machine in WinUI 3 Controls Gallery, if it does this issue must be investigated further

Yes, I can swipe from left to right and reveal the "accept" and the "flag" button in the SwipeView.

When I do the same action on one of the messages in the Unigram, it does not work.

I tried to swipe in the chat list and it works. Looks like it only fails in the chat UI.

@caeslucio
Copy link

caeslucio commented Apr 21, 2022

I've using a Windows 10 touchscreen laptop Dell 15r 5537, and I'm unable to use swipe to reply on current version of Unigram, both Store (8.6.7182.0) and Direct (8.7.7352.0) versions.

@caeslucio
Copy link

On touchscreen I tried to swipe in the chat list and it works here too

@caeslucio
Copy link

But it working like in the chat UI, because when I swipe to right it shows the reply icon

@lloydo3000
Copy link

I tried to swipe in the chat list and it works. Looks like it only fails in the chat UI.

Same for me

@MarcAnt01
Copy link
Collaborator

@caeslucio @lloydo3000 this is not related, since here the user here is unable both to reply and forward the message with the gestures, while your issue seems to be the chats forwarding menu not loading, while gestures are working properly, please consider opening a separated ticket

@lloydo3000
Copy link

lloydo3000 commented Apr 22, 2022 via email

@Jack-Works
Copy link
Author

I just upgraded to Windows 11 22H2, and with Unigram 8.6 (7182) this problem no longer existed. Another of my PC is in Windows 10 21H2 Unigram 8.6 (7182), this problem still exists.

@FrayxRulez
Copy link
Collaborator

Yeah, late comment here. I believe that the regression was introduced by this commit and I didn't notice because there was a (undocumented) breaking change in Windows 11: 2af040b

@FrayxRulez FrayxRulez reopened this Sep 6, 2022
@FrayxRulez
Copy link
Collaborator

Doesn't seem to be fixed actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants