Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniswap interface is not compatible with 1559 type 2 tx #2115

Closed
crazybae opened this issue Jul 26, 2021 · 4 comments · Fixed by #2121
Closed

Uniswap interface is not compatible with 1559 type 2 tx #2115

crazybae opened this issue Jul 26, 2021 · 4 comments · Fixed by #2121
Assignees
Labels
bug Something isn't working p0 Very important to fix

Comments

@crazybae
Copy link

crazybae commented Jul 26, 2021

Bug Description

We are developing a chrome extension-based wallet, called Dekey (www.dekey.app).
It fully supports coin/token transfer and Dapp-browsing in ethereum based chains including layer 2.

Recently, we have completed the development of EIP1559 type 2 tx functions and is testing in various Dapps including Uniswap in ropsten and rinkeby. The production build will be deployed in the chrome app store at the end of this week.

As you know, there is no 'gasPrice' field in the type 2 tx, instead 'maxPriorityFeePerGas' and 'maxFeePerGas' should be inserted. As shown in the attached image, Uniswap interface in ropsten still seems to require 'gasPrice' field in the tx result (delivered by a wallet) though the tx is processed well as a type 2 in the chain (see the following url).

https://ropsten.etherscan.io/tx/0x16a6a340df23f7f1978a5b54ff4e648c2c04eae4cf4a701024ac6ef73e7de715

Steps to Reproduce

  1. Perform EIP1559 type 2 tx in Uniswap ropsten
  2. You will meet the error like the attached image
  3. See the tx result in etherscan

Expected Behavior
Uniswap interface should process the tx result differently depending on the tx type.

image

@crazybae crazybae added the bug Something isn't working label Jul 26, 2021
@moodysalem moodysalem changed the title Uniswap interface is not compatible with 1599 type 2 tx Uniswap interface is not compatible with 1559 type 2 tx Jul 26, 2021
@moodysalem moodysalem added the p0 Very important to fix label Jul 26, 2021
@moodysalem
Copy link
Contributor

moodysalem commented Jul 26, 2021

London hard fork coming to mainnet in a week or two, need to fix this ASAP, I think it's just an ethers upgrade

@moodysalem
Copy link
Contributor

@moodysalem
Copy link
Contributor

@crazybae would you mind testing the PR deployment preview? https://uniswap-interface-git-upgrade-ethers-eip1559-uniswap.vercel.app/

@crazybae
Copy link
Author

I works perfectly. Thanks for your time and effort.
https://ropsten.etherscan.io/tx/0x11fa5739d60e4645487970783967482618c7aa903e8e23746b0c6154a888f567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0 Very important to fix
Projects
None yet
2 participants