Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test SafeCallback #183

Closed
snreynolds opened this issue Jul 22, 2024 · 1 comment · Fixed by #220
Closed

test SafeCallback #183

snreynolds opened this issue Jul 22, 2024 · 1 comment · Fixed by #220
Assignees
@saucepoint

Comments

@snreynolds
Copy link
Member

Component

General design optimization (improving efficiency, cleanliness, or developer experience)

Describe the suggested feature and problem it solves.

A lot of our peripheral contracts use SafeCallback so we should add tests. specifically noticed its missing a revert test

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response
@linear Linear
Copy link

linear bot commented Jul 22, 2024

PROTO-345 test SafeCallback

@saucepoint saucepoint self-assigned this Jul 26, 2024
This was referenced Jul 27, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saucepoint saucepoint

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test SafeCallback Uniswap/v4-periphery
SafeCallback test Uniswap/v4-periphery
2 participants
@snreynolds @saucepoint