Remove SETTLE_TAKE_PAIR command #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HickupHH3
reviewed
Oct 21, 2024
Comment on lines
32
to
34
| uint256 constant CLOSE_CURRENCY = 0x17; | ||
| uint256 constant CLEAR_OR_TAKE = 0x18; | ||
| uint256 constant SWEEP = 0x19; |
There was a problem hiding this comment.
should the subsequent actions be shifted up to replace it?
There was a problem hiding this comment.
given we do a big renumbering in #384 i feel like it makes sense to do that there as we're merging that now too
saucepoint
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While efficient, its hard for people to identify when to use it safely and when you cannot. Better to remove it and keep people safe(r).