fix: Address unknown path format error in wsl2
#667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
suggested changes
Jan 26, 2022
There was a problem hiding this comment.
Hello @snicmakino - thanks a lot for this, could you please address the formatting issues before merging?
|
Hello @pgrzesik
Thank you for pointing that out. |
pgrzesik
approved these changes
Jan 26, 2022
pgrzesik
changed the title
wsl2
|
Hi guys! First, thanks for the amazing tool that is Serverless, it is much appreciated Do you, by any chance, have an idea of when this fix will be shipped in a release? Thanks |
|
Hey @EnzoMolion - I was planning to do a release either today or early next week. |
|
Ok, thanks a lot |
|
Tested it today, it works like a charm, thanks @snicmakino and @pgrzesik |
kaochiuan
pushed a commit
to kaochiuan/serverless-python-requirements
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves the problem #371 that is occurring in wsl2.
In order to make wsl2 work as well as linux, the wsl decision was changed so that it only applies to wsl1.