Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace lodash.set with set-value #676

Merged
merged 1 commit into from
Mar 2, 2022
Merged

refactor: Replace lodash.set with set-value #676

merged 1 commit into from
Mar 2, 2022

Conversation

mhassan1
Copy link
Contributor

Resolves #675

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposal @mhassan1 - Looks like we have some failing tests at the moment - could you look into that?

@mhassan1
Copy link
Contributor Author

@pgrzesik I'm not sure how the change in this PR could be causing those failures. What do you think?

@pgrzesik
Copy link
Contributor

You're totally right, I didn't check the errors previously - it seems like there's some issue with one of the GH actions - I'm looking into it

@pgrzesik
Copy link
Contributor

Hello @mhassan1 - I believe I've fixed the CI issue, could you please rebase your branch against current master?

Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mhassan1 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency lodash.set has an unpatched CVE
2 participants