Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issue with Jump.cs #8

Open
ciro-unity opened this issue May 23, 2017 · 2 comments
Open

Possible issue with Jump.cs #8

ciro-unity opened this issue May 23, 2017 · 2 comments
Assignees

Comments

@ciro-unity
Copy link
Contributor

From Art of Jimbo on Twitter

the jump scrip, even with a 'ground' tag still seems to let player jump a little higher than they should. I thought the 'ground' tag would allow player to jump once and then drop back down (depending on gravity, drag etc) but it seems even with platform elements tagged with 'ground' you can still make player jump more than they should

@ciro-unity ciro-unity self-assigned this May 23, 2017
@Westerveld
Copy link
Contributor

a possible fix would be to add this check to the collision statement:

collisionData.contacts[0].normal == Vector2.up

This would mean that having slanted platforms would result in the user not being able to jump off them

@ciro-unity
Copy link
Contributor Author

Yeah, maybe I can check the normal in a range (so if Y is more than 0, should be a valid platform). That might introduce more bugs than fix things… we'll see. It's not a super high priority issue, but I'll leave it open as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants