Split the display code, fix #28 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2015
This was referenced Jul 6, 2015
illwieckz
force-pushed
the
split-display
branch
from
43e1af5 to
626f6a2
Compare
illwieckz
force-pushed
the
split-display
branch
from
626f6a2 to
cfd8241
Compare
- add json support to games added since Steve Teuber's patches - use xform_names instead of name_xforms since Steven Hartland's refactoring - use xform_printf() instead of fprintf() for json output - remove commented out code - use %s for a const switch seems a bit wasteful, fixing it - do not use inline tests - explicitely test pointers with NULL - escape lone backslash character too - RFC 4627 says: “JSON text SHALL be encoded in Unicode. The default encoding is UTF-8.” - iterator limit now match malloc in protocol listing - use singl-hyphen -json-protocols and -json-version options
illwieckz
force-pushed
the
split-display
branch
from
cfd8241 to
992a54a
Compare
Merged
|
Not fully used, but the requirement to split out JSON was included in #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is just unmaintainable, both standard, raw, xml and json display logic is in
qstat.cwhich is wrong.This PR split standard, raw, xml, and json display logic in dedicated c-files, create needed h-files for them, and create a h-file for templating display too to avoid redeclarations (the template code was just copy pasting some qstat.h lines, and qstat.h were copypasting some template definitions).
must be merged right after #13 and before #25 and others