Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Double-Tap reset button to Enter bootloader #5

Closed
1 of 4 tasks
zUnixorn opened this issue Mar 20, 2024 · 2 comments · Fixed by #6
Closed
1 of 4 tasks

Feature: Double-Tap reset button to Enter bootloader #5

zUnixorn opened this issue Mar 20, 2024 · 2 comments · Fixed by #6
Labels
enhancement New feature or request

Comments

@zUnixorn
Copy link
Contributor

Type of Feature Request

  • Enhancement to an existing rumcake feature
  • New feature unrelated to existing rumcake features
  • New driver for existing rumcake features
  • Support for a new MCU

Description

Hello, first of all, thank you for this amazing project. Now that there is RP2040 support, I really want to use this firmware for my Corne, instead of QMK.

In QMK there is an option to enter the UF2 Bootloader with a double-tap of the reset button. I use this feature, since my Corne PCB only exposes the reset button but not the boot button.

The feature is already implemented in my fork (here) and I could open a pull request if you are interested.

In my implementation, the feature is not exclusive to the RP2040 but can only really be used with it, since the other MCUs do not currently have an implemented jump_to_bootloader() function. I also am not sure what the best way is, to configure the timeout time, currently it can be change via an environment variable at compile-time

@zUnixorn zUnixorn added the enhancement New feature or request label Mar 20, 2024
@Univa
Copy link
Owner

Univa commented Mar 20, 2024

Feel free to open a PR, I can take a deeper look at some point. For the timeout configuration, I would just add an optional field for the #[keyboard] macro (in the KeyboardSettings struct), then pass it as an argument to your bootloader magic task. I can provide more guidance in the PR.

@zUnixorn
Copy link
Contributor Author

Thanks for the feedback. I opened a pull-request for this (#6) now

@Univa Univa linked a pull request Mar 20, 2024 that will close this issue
13 tasks
@Univa Univa closed this as completed in #6 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants