Fix "PHP Deprecated: trim(): Passing null to parameter #1 ($string) o… #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
========================================
Coverage 0.00% 0.00%
Complexity 1569 1569
========================================
Files 23 23
Lines 4262 4262
========================================
Misses 4262 4262 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -886,10 +886,10 @@ | |||
| $scrollVariables = (array)$scrollVariables; | |||
|
|
|||
| foreach ( $scrollVariables as $variable => $value ) { | |||
| Variables::setVar( [ '', '', $variable, $value ] ); | |||
| Variables::setVar( [ '', '', $variable, $value ?? '' ] ); | |||
Check warning
Code scanning / Phpmd (reported by Codacy)
Static access leads to hard to test code Warning
Universal-Omega
merged commit 811467f
into
Universal-Omega:master
21 of 24 checks passed
MrVanosh
pushed a commit
to Wikia/DynamicPageList3
that referenced
this pull request
Dec 18, 2023
…f type string is deprecated" (Universal-Omega#251)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…f type string is deprecated"