Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Pip install failure due to relativepath not being fulfilled #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PeterAlabaster
Copy link

When trying to install jac-format or jac_format via pip, I get the following:

Collecting jac-format
  Downloading https://files.pythonhosted.org/packages/78/b1/19ee7688284be98bd950d9d3b946b0f112fcf03f8dbe36b7b3664a6f285d/jac_format-0.1.1.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-mmbp3b/jac-format/setup.py", line 7, in <module>
        with open(join(_here, "../README.md")) as f:
    IOError: [Errno 2] No such file or directory: '/tmp/pip-install-mmbp3b/jac-format/../README.md'

To be clear, I'm not proposing this as the final solution as it's messy to have a duplicate LICENSE and README.md, but this fixed it for me locally, and as I can't raise issues on this repo due to it being a fork, I had to make a PR to raise it.

readme = f.read()

with open(join(_here, "../LICENSE")) as f:
with open(join(_here, "LICENSE")) as f:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the _here variable, great convention!

@seveibar
Copy link

seveibar commented Sep 5, 2020

I think this was somehow fixed in 0.1.4 because this worked for me:

[seve@coro:~]$ pip install jac_format                                                                                                                                                                                                                                                                                                   (09-05 08:53)
Defaulting to user installation because normal site-packages is not writeable
Collecting jac_format
  Downloading jac_format-0.1.4.tar.gz (9.6 kB)
Building wheels for collected packages: jac-format
  Building wheel for jac-format (setup.py) ... done
  Created wheel for jac-format: filename=jac_format-0.1.4-py3-none-any.whl size=9180 sha256=c9b4402f84f9bab546bce450dd42de2adc5b29ccadfbdca7cf5031b99e3fff72
  Stored in directory: /home/seve/.cache/pip/wheels/03/b2/e4/5d73722004cde1fbab86953901b8d5b02e457d01e9f50b4360
Successfully built jac-format
Installing collected packages: jac-format
Successfully installed jac-format-0.1.4

I also tried it in a docker container. But I'll leave this open for a bit. Can anyone confirm the issue with 0.1.4+?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants