Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 manifest attributes no longer shown as metadata attributes #973

Open
1 task done
nicolasfranck opened this issue Mar 15, 2024 · 3 comments
Open
1 task done

3 manifest attributes no longer shown as metadata attributes #973

nicolasfranck opened this issue Mar 15, 2024 · 3 comments
Assignees

Comments

@nicolasfranck
Copy link
Contributor

UV version:

 universalviewer@4.0.25

I'm submitting a:

  • bug report => please fork one of these codesandbox examples with a repro of your issue and include a link to it below

Current behavior:
Not sure if this a bug, but in UV4 IIIF v2 attributes attribution, license and logo
are added to the moreinfo-right-panel as if they were part of the metadata attribute list.

If you provide a IIIF v3 manifest however, with requiredStatement, rights and provider.0.logo,
those attributes are NOT added to the list. Is this old behaviour that is considered deprecated?
Where should the license/rights be placed?

Expected behavior:

Steps to reproduce:

@demiankatz
Copy link
Contributor

@nicolasfranck, I don't know for certain, but it seems more likely this is due to a lack of support for v3 changes than a conscious decision.

Note that the metadata panel is actually a separate component that gets included here; see: https://github.com/IIIF-Commons/iiif-metadata-component -- I suspect that reviewing that code may reveal the cause, and the solution may be a PR over there and an upgrade here.

(But apologies if I'm incorrect -- I unfortunately don't currently have enough free time to look into this myself, but I hope this proves to be a useful pointer in the right direction).

@nicolasfranck
Copy link
Contributor Author

nicolasfranck commented Mar 15, 2024

@demiankatz Yes I know about that component ;-). I'll give it a try

Notes:

@jamesmisson
Copy link
Contributor

jamesmisson commented Jun 27, 2024

I've adjusted the relevant components (iiif-metadata-component, manifesto and manifold) in a new fork, and the requiredStatement is now included in the metadata here: https://github.com/jamesmisson/manifold

I'll do the logo and license soon. I'm waiting to hear back from the IIIF devs on how this should be incorporated into the main IIIF Commons — then we can bring it over to UV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Community Sprint IN PROGRESS
Development

No branches or pull requests

3 participants