Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: symfony/event-dispatcher is required #83

Closed
1 task done
netzhuffle opened this issue May 16, 2022 · 2 comments · Fixed by #84
Closed
1 task done

[Bug]: symfony/event-dispatcher is required #83

netzhuffle opened this issue May 16, 2022 · 2 comments · Fixed by #84
Assignees
Labels
bug Something isn't working

Comments

@netzhuffle
Copy link

netzhuffle commented May 16, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Latest release added symfony/event-dispatcher as an optional dependency (according to composer.json, it is only required for dev).

Yet the code is written in a way that symfony/event-dispatcher is required. Thus an exception is triggered when e.g. a feature flag is disabled and the autoloader cannot find the associated classes, e.g. Symfony\Contracts\EventDispatcher\Event.

To reproduce

  1. Run Unleash without sentry/event-dispatcher
  2. Check for a disabled feature flag

Sample code (optional)

No response

Version

v1.5.081

Expected behavior

isEnabled() returns false instead of throwing an error or exception.

Logs (optional)

No response

Additional context (optional)

No response

@netzhuffle netzhuffle added the bug Something isn't working label May 16, 2022
Repository owner moved this from New to Done in Issues and PRs May 16, 2022
@RikudouSage
Copy link
Collaborator

Fixed in 1.5.181. Let me know if it works.

@netzhuffle
Copy link
Author

Yes, can confirm it worked. Thanks!

@netzhuffle netzhuffle changed the title [Bug]: sentry/event-dispatcher is required [Bug]: symfony/event-dispatcher is required May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants