Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require python-dateutil>=2.8.1 #266

Closed
felix-hilden opened this issue Aug 1, 2023 · 6 comments
Closed

Require python-dateutil>=2.8.1 #266

felix-hilden opened this issue Aug 1, 2023 · 6 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@felix-hilden
Copy link

Describe the bug
When installed with python-dateutil<2.8.1, importing UnleashClient raises "cannot import ParserError from dateutil.parser".

Expected behavior
UnleashClient would have been installed with the appropriate version restriction.

Additional context
Python 3.9, but I think it doesn't make a difference. The change to dateutil is this one.

This might make older versions of UnleashClient install in favor of the newest one if solvers decide that the restricted dateutil version wouldn't fit, but it's probably better to fix the issue.

@felix-hilden felix-hilden changed the title Require python-dateutil 2.8.1 Require python-dateutil>=2.8.1 Aug 1, 2023
@Tymek
Copy link
Member

Tymek commented Aug 3, 2023

Thank your for reporting this. Would you like to contribute a fix? If not, I'll add it to our priorities internally.

@Tymek Tymek added the help wanted Extra attention is needed label Aug 3, 2023
@Tymek Tymek moved this from New to Todo in Issues and PRs Aug 3, 2023
@felix-hilden
Copy link
Author

I can have a look next week if you haven't gotten to it! I know very little about the project, so if it's a trivial thing, feel free to just do it 👍🏿

@stale
Copy link

stale bot commented Sep 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 3, 2023
@Tymek Tymek added bug Something isn't working and removed stale labels Sep 4, 2023
@snosratiershad
Copy link
Contributor

@Tymek, I've an idea. As I noticed, before 2.8.1 it raised ValueError instead of ParserError in the same cases. what if instead of requiring at least a 2.8.1 version of dateutils, check the version and use ValueError instead?

@snosratiershad
Copy link
Contributor

Here's an example: #273

@snosratiershad
Copy link
Contributor

As #273 merged, now we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants