-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require python-dateutil>=2.8.1 #266
Comments
Thank your for reporting this. Would you like to contribute a fix? If not, I'll add it to our priorities internally. |
I can have a look next week if you haven't gotten to it! I know very little about the project, so if it's a trivial thing, feel free to just do it 👍🏿 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@Tymek, I've an idea. As I noticed, before 2.8.1 it raised ValueError instead of ParserError in the same cases. what if instead of requiring at least a 2.8.1 version of |
Here's an example: #273 |
As #273 merged, now we can close this issue. |
Describe the bug
When installed with python-dateutil<2.8.1, importing
UnleashClient
raises "cannot import ParserError from dateutil.parser".Expected behavior
UnleashClient would have been installed with the appropriate version restriction.
Additional context
Python 3.9, but I think it doesn't make a difference. The change to dateutil is this one.
This might make older versions of UnleashClient install in favor of the newest one if solvers decide that the restricted dateutil version wouldn't fit, but it's probably better to fix the issue.
The text was updated successfully, but these errors were encountered: