Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel timeout #95

Closed
cipriancaba opened this issue Feb 3, 2023 · 7 comments · Fixed by #99
Closed

Vercel timeout #95

cipriancaba opened this issue Feb 3, 2023 · 7 comments · Fixed by #99

Comments

@cipriancaba
Copy link

Describe the bug
We have some longer deploy times and use this to correctly enforce the result status of the vercel deployment, but after enabling debug mode, we noticed that after a while, the vercel request will timeout

FetchError: request to https://api.vercel.com/v11/now/deployments/get?url=********.vercel.app failed, reason: connect ETIMEDOUT 76.76.21.112:443

I think this is a ddos protection on vercel's side

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
It would be really helpful if we could configure the retry step (eg: as opposed to checking status every 5 seconds, we can do it every 30 seconds)

Much appreciated

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Vadorequest
Copy link
Member

Are you sure this issue is related to the number of retries?

How long does your Vercel deployment take?

@cipriancaba
Copy link
Author

It takes about 20minutes, we're statically building a ton of pages.

Just checked the code and it seems like everything happens in a while loop

while (new Date().getTime() < timeoutTime) {

Is there any chance we can add a timeout between requests? Seems like this is just hammering vercel api without any delay. I think 5secs would be nice, ideally configurable

@Vadorequest
Copy link
Member

@cipriancaba I believe #97 might solve your issue. (PR from first time contributor)

@Vadorequest
Copy link
Member

Merged through #98

Could you let me know if this change improves your issues?

@Vadorequest
Copy link
Member

This other PR should help as well.
#100

I'm closing this, let me know if anything doesn't work as expected.

@cipriancaba
Copy link
Author

Works great, much appreciated @Vadorequest

@Vadorequest
Copy link
Member

I haven't done much!

@namoscato @dlively1 are to thank for those :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants