Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider requiring SSH key, disabling password delivery #44

Open
scop opened this issue Nov 13, 2024 · 3 comments
Open

Consider requiring SSH key, disabling password delivery #44

scop opened this issue Nov 13, 2024 · 3 comments

Comments

@scop
Copy link
Member

scop commented Nov 13, 2024

For security reasons.

Further constraints: https://developers.upcloud.com/1.3/8-servers/#creating-from-a-template

Additionally, it appears that the root password is stored by the module so that it can be retrieved in cleartext. This should be rectified in case we for some reason end up keeping the password login option.

@thevilledev
Copy link

This requires some internal refinement first

@thevilledev
Copy link

thevilledev commented Nov 18, 2024

API docs for listing available templates: https://developers.upcloud.com/1.3/9-storages/#public-storages

In short:

  • If the template has template_type: "cloud-init" only SSH keys can be utilised.
  • If the template has template_type: "native" both SSH keys and one time passwords can be utilised.
  • If the template does not have template_type defined, as with private templates, show both options. It's up to the template to either utilise cloud-init or alternatively pre-baked keys.

This should be reflected in the WHMCS module logic when defining these parameters.

@adityawbwce
Copy link
Contributor

Need to discuss on the requirement, will connect with @scop @thevilledev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants